Only validate form subtype edits if subtype transactions are present
5ed90b223591
Actions

Description

Only validate form subtype edits if subtype transactions are present

Summary: Fixes T12347. Ref T12314. Validation gets called no matter what, but is only relevant if the form supports subtypes.

Test Plan: Marked/unmarked a Paste form as editable.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12347, T12314

Differential Revision: https://secure.phabricator.com/D17457

Details

Provenance

epriestley	Authored on Mar 3 2017, 9:41 PM
epriestley	Pushed on Mar 3 2017, 9:44 PM

Reviewer

chad

Differential Revision

D17457: Only validate form subtype edits if subtype transactions are present

Parents

rPd2a420d13abd: Remove needRecipients and needAwards from Badges

Branches

Unknown

Tags

Unknown

Tasks

T12314: Support formal task subtypes (like "bug" vs "feature")
T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'."

Build Status

Buildable 15885
Build 21028: Run Core Tests

Event Timeline

epriestley committed rP5ed90b223591: Only validate form subtype edits if subtype transactions are present (authored by epriestley).Mar 3 2017, 9:44 PM

epriestley added a task: T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'.".

epriestley added a task: T12314: Support formal task subtypes (like "bug" vs "feature").

Harbormaster completed building B15885: rP5ed90b223591: Only validate form subtype edits if subtype transactions are present.Mar 3 2017, 9:45 PM

Changes (1)

Path

Size

src/

applications/

transactions/

editor/

PhabricatorEditEngineConfigurationEditor.php

rP5ed90b223591

View Options

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php