Add a tooltip option to Link menu items
ClosedPublic
Actions

Authored by chad on Mar 1 2017, 7:07 PM.

Tags

None

Referenced Files

	F13203338: D17437.diff
	Tue, May 14, 11:40 PM

	F13200413: D17437.diff
	Mon, May 13, 11:54 PM

	F13187560: D17437.diff
	Sat, May 11, 4:36 AM

	Unknown Object (File)
	Fri, May 3, 3:04 AM

	Unknown Object (File)
	Mon, Apr 29, 4:48 AM

	Unknown Object (File)
	Wed, Apr 24, 10:09 PM

	Unknown Object (File)
	Sun, Apr 21, 4:21 PM

	Unknown Object (File)
	Apr 6 2024, 9:39 PM

View All 96 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12174: Home Menu Errata

Commits

rP3f1ee67972ac: Add a tooltip option to Link menu items

Summary

Ref T12174. Let's users add a tooltip to LinkProfileMenuItem

Test Plan

Add a tooltip, remove tooltip. Menu appears as expected

Diff Detail

Repository

rP Phabricator

Branch

tooltip-link (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15835
Build 20948: Run Core Tests
Build 20947: arc lint + arc unit

Event Timeline

chad created this revision.Mar 1 2017, 7:07 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2017, 7:07 PM

Harbormaster completed remote builds in B15835: Diff 41931.Mar 1 2017, 7:08 PM

Does this do anything goofy in the favorites menu?

This revision is now accepted and ready to land.Mar 1 2017, 7:15 PM

Closed by commit rP3f1ee67972ac: Add a tooltip option to Link menu items (authored by chad, committed by chad). · Explain WhyMar 1 2017, 7:16 PM

This revision was automatically updated to reflect the committed changes.

No, doesn't display there, just like Application tooltips.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

menuitem/

PhabricatorLinkProfileMenuItem.php

14 lines

Diff 41931

View Options

src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php

Add a tooltip option to Link menu itemsClosedPublicActions