Add a tooltip option to Link menu items
ClosedPublic
Actions

Authored by chad on Mar 1 2017, 7:07 PM.

Tags

None

Referenced Files

	F15458469: D17437.id.diff
	Mon, Mar 31, 3:58 AM

	F15453726: D17437.diff
	Sat, Mar 29, 1:55 PM

	F15426840: D17437.id41931.diff
	Sun, Mar 23, 11:04 AM

	F15411705: D17437.id.diff
	Wed, Mar 19, 9:33 AM

	F15403304: D17437.diff
	Tue, Mar 18, 2:41 AM

	F15389452: D17437.id.diff
	Sat, Mar 15, 5:16 AM

	F15387297: D17437.id41931.diff
	Sat, Mar 15, 2:10 AM

	F15374265: D17437.diff
	Wed, Mar 12, 6:02 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12174: Home Menu Errata

Commits

rP3f1ee67972ac: Add a tooltip option to Link menu items

Summary

Ref T12174. Let's users add a tooltip to LinkProfileMenuItem

Test Plan

Add a tooltip, remove tooltip. Menu appears as expected

Diff Detail

Repository

rP Phabricator

Branch

tooltip-link (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15835
Build 20948: Run Core Tests
Build 20947: arc lint + arc unit

Event Timeline

chad created this revision.Mar 1 2017, 7:07 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2017, 7:07 PM

Harbormaster completed remote builds in B15835: Diff 41931.Mar 1 2017, 7:08 PM

Does this do anything goofy in the favorites menu?

This revision is now accepted and ready to land.Mar 1 2017, 7:15 PM

Closed by commit rP3f1ee67972ac: Add a tooltip option to Link menu items (authored by chad, committed by chad). · Explain WhyMar 1 2017, 7:16 PM

This revision was automatically updated to reflect the committed changes.

No, doesn't display there, just like Application tooltips.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

menuitem/

PhabricatorLinkProfileMenuItem.php

14 lines

Diff 41931

View Options

src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php

Add a tooltip option to Link menu itemsClosedPublicActions