Differential D17269

Add a "Red/Green Colorblind" accessibility mode, make all web UIs and email respect it
ClosedPublic
Actions

Authored by epriestley on Jan 31 2017, 1:38 AM.

Details

Reviewers

chad

Maniphest Tasks

T12060: Colorblind accessibility for red/green highlighting in e-mails
T12172: Better color scheme for diffs

Commits

rP84aff44bcd64: Add a "Red/Green Colorblind" accessibility mode, make all web UIs and email…

Summary

Fixes T12172. Fixes T12060. This allows runtime code building CSS for mail to read CSS variables, then makes all the code do that.

It reverts the non-colorblind red/green to the colors in use before T12060, which seem better for non-colorblind users since no one really complained?

Test Plan

Viewed code diffs in Web UI.
Viewed prose diffs in Web UI.
Viewed code diffs in email.
Viewed prose diffs in email.

All modes respected the accessibility color scheme.

Diff Detail

Repository

rP Phabricator

Branch

accessibility1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15738
Build 20798: Run Core Tests
Build 20797: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2017, 1:38 AM

Waiting on real colors (or, at least, colors with a better chance of working) from T12172.

Harbormaster completed remote builds in B15427: Diff 41546.Jan 31 2017, 1:39 AM

epriestley mentioned this in T12172: Better color scheme for diffs.Feb 12 2017, 1:10 PM

I'm ready to ship this and iterate. I miss the old colors.

chad accepted this revision.Feb 23 2017, 6:20 PM

Label this mode "Deuteranopia" explicitly because there are 4+ types of red/green colorblindness (?) but these colors were picked based on users with deuteranopia, from what I can determine in T12060 (and are possibly worse for users with protanomaly, per T12172).

This revision is now accepted and ready to land.Feb 23 2017, 6:55 PM

Harbormaster completed remote builds in B15738: Diff 41841.Feb 23 2017, 6:56 PM

Closed by commit rP84aff44bcd64: Add a "Red/Green Colorblind" accessibility mode, make all web UIs and email… (authored by epriestley, committed by epriestley). · Explain WhyFeb 23 2017, 6:57 PM

This revision was automatically updated to reflect the committed changes.

chad awarded a token.Feb 23 2017, 7:06 PM