Page MenuHomePhabricator

Add a "Red/Green Colorblind" accessibility mode, make all web UIs and email respect it
ClosedPublic

Authored by epriestley on Jan 31 2017, 1:38 AM.
Tags
None
Referenced Files
F12842435: D17269.id41841.diff
Thu, Mar 28, 10:01 PM
F12837898: D17269.diff
Thu, Mar 28, 5:37 PM
Unknown Object (File)
Feb 3 2024, 2:17 PM
Unknown Object (File)
Jan 25 2024, 4:09 AM
Unknown Object (File)
Dec 27 2023, 9:36 AM
Unknown Object (File)
Dec 27 2023, 9:36 AM
Unknown Object (File)
Dec 27 2023, 9:36 AM
Unknown Object (File)
Dec 27 2023, 9:36 AM
Subscribers
None
Tokens
"100" token, awarded by chad.

Details

Summary

Fixes T12172. Fixes T12060. This allows runtime code building CSS for mail to read CSS variables, then makes all the code do that.

It reverts the non-colorblind red/green to the colors in use before T12060, which seem better for non-colorblind users since no one really complained?

Test Plan
  • Viewed code diffs in Web UI.
  • Viewed prose diffs in Web UI.
  • Viewed code diffs in email.
  • Viewed prose diffs in email.

All modes respected the accessibility color scheme.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Waiting on real colors (or, at least, colors with a better chance of working) from T12172.

I'm ready to ship this and iterate. I miss the old colors.

  • Label this mode "Deuteranopia" explicitly because there are 4+ types of red/green colorblindness (?) but these colors were picked based on users with deuteranopia, from what I can determine in T12060 (and are possibly worse for users with protanomaly, per T12172).
This revision is now accepted and ready to land.Feb 23 2017, 6:55 PM
This revision was automatically updated to reflect the committed changes.