Fix "Create Form" link destinations when editing edit forms
ClosedPublic
Actions

Authored by epriestley on Feb 22 2017, 10:34 PM.

Tags

None

Referenced Files

	F13267851: D17398.diff
	Wed, May 29, 4:18 AM

	F13267229: D17398.id.diff
	Wed, May 29, 3:02 AM

	F13258178: D17398.id.diff
	Sun, May 26, 7:16 AM

	F13251826: D17398.diff
	Sat, May 25, 12:47 AM

	F13239439: D17398.id41835.diff
	Wed, May 22, 3:02 AM

	F13224781: D17398.id41835.diff
	Sun, May 19, 10:54 AM

	F13224780: D17398.id41836.diff
	Sun, May 19, 10:53 AM

	F13224779: D17398.diff
	Sun, May 19, 10:53 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12301: `Create Form` always leads to page creating forms for configuring forms

Commits

rP4540ae028a6e: Fix "Create Form" link destinations when editing edit forms

Summary

Fixes T12301. In D17372, this changed to use generic EditEngines instead of the proper runtime engine. Normally this doesn't matter, but can in this case.

After loading the configurations normally, swap their attached engines for the specific configured runtime engine we're currently executing.

Test Plan

Clicked "Create Form" from the Maniphest form list, saw it go to "Create Maniphest Form", not "Create Generic Meta-Form".

Diff Detail

Repository

rP Phabricator

Branch

edit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15732
Build 20788: Run Core Tests
Build 20787: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 22 2017, 10:34 PM

Harbormaster completed remote builds in B15732: Diff 41835.Feb 22 2017, 10:35 PM

chad accepted this revision.Feb 22 2017, 10:35 PM

This revision is now accepted and ready to land.Feb 22 2017, 10:35 PM

Closed by commit rP4540ae028a6e: Fix "Create Form" link destinations when editing edit forms (authored by epriestley, committed by epriestley). · Explain WhyFeb 22 2017, 11:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

7 lines

Diff 41835

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Fix "Create Form" link destinations when editing edit formsClosedPublicActions