Page MenuHomePhabricator

Be less strict when detecting dead daemons
ClosedPublic

Authored by epriestley on Feb 22 2017, 10:09 PM.
Tags
None
Referenced Files
F13204795: D17397.diff
Wed, May 15, 1:08 AM
F13187927: D17397.diff
Sat, May 11, 4:51 AM
Unknown Object (File)
Tue, May 7, 8:03 AM
Unknown Object (File)
Fri, May 3, 7:47 AM
Unknown Object (File)
Sun, Apr 28, 6:28 AM
Unknown Object (File)
Thu, Apr 25, 1:44 AM
Unknown Object (File)
Fri, Apr 19, 6:17 PM
Unknown Object (File)
Apr 12 2024, 11:33 AM
Subscribers
None

Details

Summary

Fixes T12306. Currently, we warn about daemons not running even if they're in normal "alive" states, particularly "waiting to restart after a failure".

This check was made more strict in D12088, back when we tried to version check running daemons. Since we implemented auto-restart-after-config-change we don't do this anymore, so it should be fine to make this more lax again.

Test Plan
  • Faked an exception for all tasks.
  • Before patch: reloading the daemon setup error sometimes raised a false positive ("waiting" daemon detected as dead).
  • After patch: daemon setup error no longer triggers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable