Page MenuHomePhabricator

Be less strict when detecting dead daemons
ClosedPublic

Authored by epriestley on Feb 22 2017, 10:09 PM.
Tags
None
Referenced Files
F19080348: D17397.id41832.diff
Tue, Dec 2, 12:58 AM
F19074747: D17397.id.diff
Mon, Dec 1, 6:42 AM
F19068310: D17397.diff
Sun, Nov 30, 11:45 AM
F18975971: D17397.diff
Nov 16 2025, 11:11 AM
F18917906: D17397.id.diff
Nov 9 2025, 10:05 AM
F18844631: D17397.id.diff
Oct 29 2025, 6:52 AM
F18843116: D17397.diff
Oct 28 2025, 9:01 PM
F18841871: D17397.diff
Oct 28 2025, 11:55 AM
Subscribers
None

Details

Summary

Fixes T12306. Currently, we warn about daemons not running even if they're in normal "alive" states, particularly "waiting to restart after a failure".

This check was made more strict in D12088, back when we tried to version check running daemons. Since we implemented auto-restart-after-config-change we don't do this anymore, so it should be fine to make this more lax again.

Test Plan
  • Faked an exception for all tasks.
  • Before patch: reloading the daemon setup error sometimes raised a false positive ("waiting" daemon detected as dead).
  • After patch: daemon setup error no longer triggers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable