Page MenuHomePhabricator

Add limit (maximum simultaneous commands) and throttle (delay between commands) to Phage
ClosedPublic

Authored by epriestley on Feb 22 2017, 9:49 PM.
Tags
None
Referenced Files
F15468046: D17396.diff
Thu, Apr 3, 7:41 PM
F15467048: D17396.id.diff
Thu, Apr 3, 12:11 PM
F15466109: D17396.id41831.diff
Thu, Apr 3, 1:41 AM
F15451319: D17396.diff
Fri, Mar 28, 9:26 PM
F15445311: D17396.id.diff
Thu, Mar 27, 1:25 PM
F15445262: D17396.diff
Thu, Mar 27, 1:11 PM
F15419664: D17396.id.diff
Fri, Mar 21, 7:51 AM
F15417797: D17396.id41833.diff
Thu, Mar 20, 6:40 PM
Subscribers
None

Details

Summary

Ref T12218. Ref T2794. This just provides a couple of general purpose tools to slow Phage down a bit if the speed is getting TOO EXTREME.

In particular, secure updates from itself so if all 4 nodes get hit simultaneously the deploy doesn't work. It deploys cleanly with --limit 1.

A separate change to the phage remote workflow in Instances exposes these options as flags:

  • --limit: Run only this many commands simultaneously.
  • --throttle: Wait this long between starting commands (for example, --throttle 0.25 will only start 4 commands per second).
Test Plan
  • Ran phage remote status on secure with various --throttle and --limit arguments, and without any arguments.
  • Ran phage remote upgrade --limit 1 on secure, got a clean upgrade.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable