Page MenuHomePhabricator

Add limit (maximum simultaneous commands) and throttle (delay between commands) to Phage
ClosedPublic

Authored by epriestley on Feb 22 2017, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 7:11 AM
Unknown Object (File)
Thu, Feb 29, 6:46 AM
Unknown Object (File)
Feb 9 2024, 9:25 PM
Unknown Object (File)
Feb 3 2024, 2:43 PM
Unknown Object (File)
Jan 24 2024, 10:06 PM
Unknown Object (File)
Jan 22 2024, 7:32 PM
Unknown Object (File)
Dec 27 2023, 9:57 AM
Unknown Object (File)
Dec 21 2023, 4:35 PM
Subscribers
None

Details

Summary

Ref T12218. Ref T2794. This just provides a couple of general purpose tools to slow Phage down a bit if the speed is getting TOO EXTREME.

In particular, secure updates from itself so if all 4 nodes get hit simultaneously the deploy doesn't work. It deploys cleanly with --limit 1.

A separate change to the phage remote workflow in Instances exposes these options as flags:

  • --limit: Run only this many commands simultaneously.
  • --throttle: Wait this long between starting commands (for example, --throttle 0.25 will only start 4 commands per second).
Test Plan
  • Ran phage remote status on secure with various --throttle and --limit arguments, and without any arguments.
  • Ran phage remote upgrade --limit 1 on secure, got a clean upgrade.

Diff Detail

Repository
rPHU libphutil
Branch
phage3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15728
Build 20783: Run Core Tests
Build 20782: arc lint + arc unit