Page MenuHomePhabricator

Revert "Restrict all crumbs to 240 max width" for this release
ClosedPublic

Authored by epriestley on Feb 17 2017, 11:34 PM.
Tags
None
Referenced Files
F13226964: D17382.id.diff
Mon, May 20, 12:26 AM
F13206257: D17382.id41792.diff
Wed, May 15, 6:38 AM
F13205629: D17382.diff
Wed, May 15, 2:14 AM
F13189593: D17382.diff
Sat, May 11, 6:13 AM
F13180599: D17382.diff
Thu, May 9, 1:17 AM
Unknown Object (File)
Tue, May 7, 9:53 AM
Unknown Object (File)
Fri, May 3, 9:43 AM
Unknown Object (File)
Thu, Apr 25, 3:21 AM
Subscribers
None

Details

Summary

Ref T12287. See D17361. That fixed a mostly-theoretical bug with crumbs named things like "MMMMMMMMMMMMMMMMMMMM", but caused a less-theoretical buggy side effect in Safari.

For now, just keep the "MMMMMMMM" crumbs around since that's the easiest/least-bad/safest fix prior to the release cut. We can fix this more broadly when we have more time to look at it.

Test Plan

Looked at profiles, saw the entire name for "hector" and the too-long-crumb for "MMMMM".

Diff Detail

Repository
rP Phabricator
Branch
crumbwidth
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15686
Build 20722: Run Core Tests
Build 20721: arc lint + arc unit