Page MenuHomePhabricator

Add PhageActions to libphutil
ClosedPublic

Authored by epriestley on Feb 17 2017, 11:14 PM.
Tags
None
Referenced Files
F15460011: D17380.id41798.diff
Mon, Mar 31, 7:11 PM
F15459050: D17380.id41789.diff
Mon, Mar 31, 9:23 AM
F15453639: D17380.id41790.diff
Sat, Mar 29, 1:17 PM
F15453482: D17380.id.diff
Sat, Mar 29, 12:08 PM
F15451376: D17380.diff
Fri, Mar 28, 9:46 PM
F15407264: D17380.diff
Tue, Mar 18, 4:34 PM
F15386255: D17380.id41798.diff
Sat, Mar 15, 12:14 AM
F15386250: D17380.id41790.diff
Sat, Mar 15, 12:14 AM
Subscribers
None

Details

Summary

Ref T2794. I'm not 100% sold on the design of this and it doesn't interact with any other code yet, but get deployment-related code upstream.

The overall approach I'm taking here is that you build a "plan", which is like a DOM tree of stuff you want to do, then execute the plan.

The only plan we build or execute right now goes like this:

  • Phage Plan
    • Launch a local Phage agent
      • Have that agent run a bunch of commands

...but I think this approach should be flexible enough to accommodate more complicated deployment processes in the future.

Test Plan

Successfully deployed secure without typing a bunch of different commands.

Diff Detail

Repository
rPHU libphutil
Branch
phagex
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/phage/action/PhageAgentAction.php:19XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 15684
Build 20719: Run Core Tests
Build 20718: arc lint + arc unit

Event Timeline

  • Don't write unconditionally to the debug logfile (I'll add some flags for this later).
This revision is now accepted and ready to land.Feb 17 2017, 11:52 PM
This revision was automatically updated to reflect the committed changes.