Page MenuHomePhabricator

Add PhageActions to libphutil
ClosedPublic

Authored by epriestley on Feb 17 2017, 11:14 PM.
Tags
None
Referenced Files
F14758969: D17380.diff
Wed, Jan 22, 11:01 AM
F14758923: D17380.diff
Wed, Jan 22, 10:58 AM
Unknown Object (File)
Tue, Jan 21, 10:03 AM
Unknown Object (File)
Tue, Jan 14, 8:49 AM
Unknown Object (File)
Sat, Dec 28, 2:04 PM
Unknown Object (File)
Dec 18 2024, 2:16 PM
Unknown Object (File)
Dec 18 2024, 2:16 PM
Unknown Object (File)
Dec 18 2024, 2:16 PM
Subscribers
None

Details

Summary

Ref T2794. I'm not 100% sold on the design of this and it doesn't interact with any other code yet, but get deployment-related code upstream.

The overall approach I'm taking here is that you build a "plan", which is like a DOM tree of stuff you want to do, then execute the plan.

The only plan we build or execute right now goes like this:

  • Phage Plan
    • Launch a local Phage agent
      • Have that agent run a bunch of commands

...but I think this approach should be flexible enough to accommodate more complicated deployment processes in the future.

Test Plan

Successfully deployed secure without typing a bunch of different commands.

Diff Detail

Repository
rPHU libphutil
Branch
phagex
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/phage/action/PhageAgentAction.php:19XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 15683
Build 20717: Run Core Tests
Build 20716: arc lint + arc unit

Event Timeline

  • Don't write unconditionally to the debug logfile (I'll add some flags for this later).
This revision is now accepted and ready to land.Feb 17 2017, 11:52 PM
This revision was automatically updated to reflect the committed changes.