Page MenuHomePhabricator

Make Phage agents stream output continuously
ClosedPublic

Authored by epriestley on Feb 17 2017, 10:42 PM.
Tags
None
Referenced Files
F13989851: D17378.id.diff
Mon, Oct 21, 11:29 PM
F13989455: D17378.id41797.diff
Mon, Oct 21, 8:34 PM
Unknown Object (File)
Sep 15 2024, 1:11 PM
Unknown Object (File)
Sep 5 2024, 10:55 PM
Unknown Object (File)
Aug 29 2024, 11:33 PM
Unknown Object (File)
Aug 29 2024, 2:10 PM
Unknown Object (File)
Aug 28 2024, 8:42 AM
Unknown Object (File)
Aug 25 2024, 10:16 AM
Subscribers
None

Details

Summary

Ref T2794. Currently, the Phage agent waits until the remote command completes before sending output back to the controller.

Instead, stream output continuously.

Also work around some kind of weirdness with error reporting that I hit but couldn't immediately figure out (maybe PHP7-related?).

Test Plan

Ran bin/phage remote --hosts ... upgrade, etc., and saw a steady stream of output across multiple hosts.

Diff Detail

Repository
rPHU libphutil
Branch
phage3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15680
Build 20711: Run Core Tests
Build 20710: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 17 2017, 11:50 PM
This revision was automatically updated to reflect the committed changes.