Page MenuHomePhabricator

Make Phage agents stream output continuously
ClosedPublic

Authored by epriestley on Feb 17 2017, 10:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 3:18 AM
Unknown Object (File)
Sun, Feb 9, 3:18 AM
Unknown Object (File)
Sun, Feb 9, 3:18 AM
Unknown Object (File)
Wed, Jan 29, 10:17 AM
Unknown Object (File)
Fri, Jan 24, 7:13 PM
Unknown Object (File)
Fri, Jan 24, 7:12 PM
Unknown Object (File)
Fri, Jan 24, 7:12 PM
Unknown Object (File)
Fri, Jan 24, 12:14 AM
Subscribers
None

Details

Summary

Ref T2794. Currently, the Phage agent waits until the remote command completes before sending output back to the controller.

Instead, stream output continuously.

Also work around some kind of weirdness with error reporting that I hit but couldn't immediately figure out (maybe PHP7-related?).

Test Plan

Ran bin/phage remote --hosts ... upgrade, etc., and saw a steady stream of output across multiple hosts.

Diff Detail

Repository
rPHU libphutil
Branch
phage3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15680
Build 20711: Run Core Tests
Build 20710: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 17 2017, 11:50 PM
This revision was automatically updated to reflect the committed changes.