Page MenuHomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode
ClosedPublic

Authored by epriestley on Feb 16 2017, 2:20 PM.
Tags
None
Referenced Files
F13136002: D17369.id41767.diff
Thu, May 2, 11:46 AM
Unknown Object (File)
Wed, May 1, 8:47 AM
Unknown Object (File)
Wed, May 1, 5:16 AM
Unknown Object (File)
Sun, Apr 28, 1:55 PM
Unknown Object (File)
Thu, Apr 25, 5:15 AM
Unknown Object (File)
Wed, Apr 24, 9:58 PM
Unknown Object (File)
Tue, Apr 23, 9:32 PM
Unknown Object (File)
Sun, Apr 21, 3:56 PM
Subscribers
None

Details

Summary

See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan

Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Branch
stan1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15662
Build 20682: Run Core Tests
Build 20681: arc lint + arc unit