Page MenuHomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode
ClosedPublic

Authored by epriestley on Feb 16 2017, 2:20 PM.
Tags
None
Referenced Files
F13043992: D17369.diff
Wed, Apr 17, 3:02 PM
Unknown Object (File)
Thu, Apr 11, 7:12 AM
Unknown Object (File)
Mon, Apr 8, 12:48 AM
Unknown Object (File)
Fri, Apr 5, 2:08 PM
Unknown Object (File)
Mon, Apr 1, 4:35 PM
Unknown Object (File)
Sat, Mar 30, 4:10 AM
Unknown Object (File)
Sun, Mar 24, 4:24 AM
Unknown Object (File)
Mar 11 2024, 11:59 PM
Subscribers
None

Details

Summary

See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan

Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable