Page MenuHomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode
ClosedPublic

Authored by epriestley on Feb 16 2017, 2:20 PM.
Tags
None
Referenced Files
F14380089: D17369.id41766.diff
Sat, Dec 21, 3:32 AM
Unknown Object (File)
Thu, Dec 19, 8:10 AM
Unknown Object (File)
Sun, Dec 15, 10:46 AM
Unknown Object (File)
Thu, Dec 5, 3:36 AM
Unknown Object (File)
Wed, Dec 4, 6:17 AM
Unknown Object (File)
Thu, Nov 28, 11:29 AM
Unknown Object (File)
Thu, Nov 28, 12:25 AM
Unknown Object (File)
Fri, Nov 22, 7:09 PM
Subscribers
None

Details

Summary

See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan

Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Branch
stan1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15662
Build 20682: Run Core Tests
Build 20681: arc lint + arc unit