Fix missing setQuoteRef() on Commit detail pages in Diffusion
ClosedPublic
Actions

Authored by epriestley on Feb 13 2017, 3:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 20, 11:51 AM

	Unknown Object (File)
	Thu, Apr 11, 9:56 AM

	Unknown Object (File)
	Tue, Apr 9, 4:45 AM

	Unknown Object (File)
	Sat, Apr 6, 12:56 AM

	Unknown Object (File)
	Sat, Apr 6, 12:54 AM

	Unknown Object (File)
	Fri, Mar 29, 4:27 AM

	Unknown Object (File)
	Thu, Mar 28, 8:28 PM

	Unknown Object (File)
	Wed, Mar 27, 6:38 PM

View All Files

Subscribers

None

Details

Reviewers

avivey
chad

Maniphest Tasks

T12253: null in remarkup rather than comment reference when quoting a comment in audit

Commits

rP037c749ef332: Fix missing setQuoteRef() on Commit detail pages in Diffusion

Summary

Fixes T12253.

Test Plan

Before change: used "Quote Comment", saw "In null, alice wrote:" in quoted text.
After change: used "Quote Comment", saw proper reference to the commit/page. Clicked reference, was sent to the comment properly.

Screen Shot 2017-02-13 at 7.39.49 AM.png (523×715 px, 59 KB)

Diff Detail

Repository

rP Phabricator

Branch

quote1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15608
Build 20597: Run Core Tests
Build 20596: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2017, 3:42 PM

Harbormaster completed remote builds in B15608: Diff 41709.Feb 13 2017, 3:43 PM

¯\_(ツ)_/¯

This revision is now accepted and ready to land.Feb 13 2017, 3:43 PM

Closed by commit rP037c749ef332: Fix missing setQuoteRef() on Commit detail pages in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyFeb 13 2017, 3:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionCommitController.php

4 lines

Diff 41709

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Fix missing setQuoteRef() on Commit detail pages in DiffusionClosedPublicActions