Page MenuHomePhabricator
Differential D17330

Don't stem "words" with a "." or "_" in them
ClosedPublic
Actions

Authored by epriestley on Feb 9 2017, 7:27 PM.
Tags
None
Referenced Files
F14496653: D17330.id41680.diff
Fri, Jan 3, 2:43 PM
Unknown Object (File)
Tue, Dec 31, 4:17 PM
Unknown Object (File)
Mon, Dec 30, 7:37 AM
Unknown Object (File)
Thu, Dec 26, 3:04 AM
Unknown Object (File)
Mon, Dec 16, 11:54 PM
Unknown Object (File)
Mon, Dec 9, 6:42 AM
Unknown Object (File)
Sun, Dec 8, 10:28 PM
Unknown Object (File)
Fri, Dec 6, 11:41 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12106: task search not finding task with full word match
Commits
rPHU58fb3b94464e: (stable) Promote 2017 Week 6
rPHU82f71f62129b: Don't stem "words" with a "." or "_" in them
Summary

Fixes T12106. It is correct for us to stem "oddly-proportioned", but not "oddlyproportioned.com" or "maniphest.levelup" or "ad_hoc_token_thing".

Test Plan
  • Added a bunch of test coverage.
  • Created a task named "apples.bananas ducks_quacks". Found it by searching for "apples.bananas" and "ducks_quacks".

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
search/
12 lines
__tests__/
12 lines

Diff 41680

View Options

src/search/PhutilSearchStemmer.php

Loading...
View Options

src/search/__tests__/PhutilSearchStemmerTestCase.php

Loading...
Phabricator · Built by Phacility