Page MenuHomePhabricator
Differential D17330

Don't stem "words" with a "." or "_" in them
ClosedPublic
Actions

Authored by epriestley on Feb 9 2017, 7:27 PM.
Tags
None
Referenced Files
F13060682: D17330.diff
Fri, Apr 19, 6:13 PM
Unknown Object (File)
Tue, Apr 16, 4:34 PM
Unknown Object (File)
Sat, Apr 13, 7:51 AM
Unknown Object (File)
Sat, Apr 13, 1:33 AM
Unknown Object (File)
Wed, Apr 10, 2:14 AM
Unknown Object (File)
Wed, Apr 10, 12:25 AM
Unknown Object (File)
Sun, Mar 31, 2:41 PM
Unknown Object (File)
Feb 3 2024, 2:32 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12106: task search not finding task with full word match
Commits
rPHU58fb3b94464e: (stable) Promote 2017 Week 6
rPHU82f71f62129b: Don't stem "words" with a "." or "_" in them
Summary

Fixes T12106. It is correct for us to stem "oddly-proportioned", but not "oddlyproportioned.com" or "maniphest.levelup" or "ad_hoc_token_thing".

Test Plan
  • Added a bunch of test coverage.
  • Created a task named "apples.bananas ducks_quacks". Found it by searching for "apples.bananas" and "ducks_quacks".

Diff Detail

Repository
rPHU libphutil
Branch
search1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15576
Build 20550: Run Core Tests
Build 20549: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
search/
12 lines
__tests__/
12 lines

Diff 41679

View Options

src/search/PhutilSearchStemmer.php

Loading...
View Options

src/search/__tests__/PhutilSearchStemmerTestCase.php

Loading...
Phabricator · Built by Phacility