Fix display of current file on Macro creation
ClosedPublic
Actions

Authored by epriestley on Feb 4 2017, 1:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 4:20 PM

	Unknown Object (File)
	Sun, Dec 8, 6:45 PM

	Unknown Object (File)
	Thu, Dec 5, 7:31 AM

	Unknown Object (File)
	Mon, Dec 2, 2:18 PM

	Unknown Object (File)
	Nov 20 2024, 6:49 AM

	Unknown Object (File)
	Nov 10 2024, 8:17 PM

	Unknown Object (File)
	Nov 4 2024, 1:56 AM

	Unknown Object (File)
	Oct 22 2024, 3:11 PM

View All Files

Subscribers

None

Details

Reviewers

20after4
chad

Commits

rP281e9849ed23: Fix display of current file on Macro creation

Summary

This could hit an obscure fatal.

Test Plan

Create a macro.
Upload a file, but don't give it a name.
Before: fatal.
After:

Screen Shot 2017-02-03 at 5.02.43 PM.png (967×1 px, 130 KB)

Diff Detail

Repository

rP Phabricator

Branch

macro1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15528
Build 20477: Run Core Tests
Build 20476: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 4 2017, 1:05 AM

Harbormaster completed remote builds in B15528: Diff 41631.Feb 4 2017, 1:06 AM

epriestley mentioned this in Z1336: General Chat.Feb 4 2017, 1:06 AM

chad accepted this revision.Feb 4 2017, 1:07 AM

This revision is now accepted and ready to land.Feb 4 2017, 1:07 AM

Closed by commit rP281e9849ed23: Fix display of current file on Macro creation (authored by epriestley, committed by epriestley). · Explain WhyFeb 4 2017, 1:10 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroEditController.php

1 line

Diff 41631

View Options

src/applications/macro/controller/PhabricatorMacroEditController.php

Fix display of current file on Macro creationClosedPublicActions