Page MenuHomePhabricator

Add clearer saved search options in ApplicationSearch
ClosedPublic

Authored by chad on Feb 3 2017, 4:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 2:32 AM
Unknown Object (File)
Sun, Dec 22, 6:19 PM
Unknown Object (File)
Mon, Dec 2, 11:25 PM
Unknown Object (File)
Nov 14 2024, 7:14 AM
Unknown Object (File)
Nov 9 2024, 12:53 PM
Unknown Object (File)
Nov 9 2024, 3:09 AM
Unknown Object (File)
Nov 6 2024, 3:14 AM
Unknown Object (File)
Oct 22 2024, 2:12 AM
Subscribers

Details

Summary

Ref T5307, Makes these buttons a little more clear visually and verbosely. Adds white icons for blue buttons.

Test Plan

Test saving a search, viewing button changes on various form pages / uiexamples.

Diff Detail

Repository
rP Phabricator
Branch
aphront-button (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15513
Build 20455: Run Core Tests
Build 20454: arc lint + arc unit

Event Timeline

Having two different blue buttons feels a little weird to me at first glance, but maybe just a familiarity issue.

This revision is now accepted and ready to land.Feb 3 2017, 1:39 PM

I knew we had the function and spent a good 20 seconds looking for it, kept missing because it was grey

This revision was automatically updated to reflect the committed changes.