Page MenuHomePhabricator
Differential D17275

Put Project "Manage" item back
ClosedPublic
Actions

Authored by epriestley on Jan 31 2017, 7:57 PM.
Tags
None
Referenced Files
F15462674: D17275.id41562.diff
Tue, Apr 1, 4:42 PM
F15460286: D17275.id41562.diff
Mon, Mar 31, 9:29 PM
F15459583: D17275.id41560.diff
Mon, Mar 31, 2:21 PM
F15454140: D17275.diff
Sat, Mar 29, 4:31 PM
F15447621: D17275.diff
Fri, Mar 28, 12:42 AM
F15424413: D17275.id41562.diff
Sat, Mar 22, 10:13 PM
F15411928: D17275.id41562.diff
Wed, Mar 19, 10:23 AM
F15388943: D17275.id41562.diff
Sat, Mar 15, 4:42 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12174: Home Menu Errata
Commits
rP2a527a51f26d: Put Project "Manage" item back
Summary

Ref T12174. This isn't really a "newManageItem()" since Projects have a separate manage screen.

That is, I incorrectly changed the "Manage [This Project]" item into a "Edit Menu" item, so some options (like "Archive Project") incorrectly became inaccessible.

Test Plan

Viewed a project, saw the right menu item, clicked it, could archive/etc project. Also edited the menu.

Diff Detail

Repository
rP Phabricator
Branch
home3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15458
Build 20369: Run Core Tests
Build 20368: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2017, 7:57 PM
Harbormaster completed remote builds in B15458: Diff 41560.Jan 31 2017, 7:58 PM
chad accepted this revision.Jan 31 2017, 8:02 PM
This revision is now accepted and ready to land.Jan 31 2017, 8:02 PM
Closed by commit rP2a527a51f26d: Put Project "Manage" item back (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2017, 8:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
engine/
4 lines

Diff 41560

View Options

src/applications/project/engine/PhabricatorProjectProfileMenuEngine.php

Loading...
Phabricator · Built by Phacility