Put Project "Manage" item back
ClosedPublic
Actions

Authored by epriestley on Jan 31 2017, 7:57 PM.

Tags

None

Referenced Files

	F15388943: D17275.id41562.diff
	Sat, Mar 15, 4:42 AM

	F15383817: D17275.diff
	Fri, Mar 14, 6:02 PM

	F15382708: D17275.diff
	Fri, Mar 14, 2:01 PM

	F15379216: D17275.id41562.diff
	Thu, Mar 13, 7:27 PM

	Unknown Object (File)
	Feb 13 2025, 6:25 AM

	Unknown Object (File)
	Jan 23 2025, 7:10 PM

	Unknown Object (File)
	Jan 22 2025, 9:33 PM

	Unknown Object (File)
	Jan 9 2025, 10:36 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12174: Home Menu Errata

Commits

rP2a527a51f26d: Put Project "Manage" item back

Summary

Ref T12174. This isn't really a "newManageItem()" since Projects have a separate manage screen.

That is, I incorrectly changed the "Manage [This Project]" item into a "Edit Menu" item, so some options (like "Archive Project") incorrectly became inaccessible.

Test Plan

Viewed a project, saw the right menu item, clicked it, could archive/etc project. Also edited the menu.

Diff Detail

Repository

rP Phabricator

Branch

home3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15458
Build 20369: Run Core Tests
Build 20368: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2017, 7:57 PM

Harbormaster completed remote builds in B15458: Diff 41560.Jan 31 2017, 7:58 PM

chad accepted this revision.Jan 31 2017, 8:02 PM

This revision is now accepted and ready to land.Jan 31 2017, 8:02 PM

Closed by commit rP2a527a51f26d: Put Project "Manage" item back (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2017, 8:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

engine/

PhabricatorProjectProfileMenuEngine.php

4 lines

Diff 41560

View Options

src/applications/project/engine/PhabricatorProjectProfileMenuEngine.php

Put Project "Manage" item backClosedPublicActions