Page MenuHomePhabricator

Remove several pieces of audit-related code
ClosedPublic

Authored by epriestley on Jan 30 2017, 9:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 4:56 PM
Unknown Object (File)
Thu, Dec 19, 7:06 PM
Unknown Object (File)
Tue, Dec 17, 3:49 AM
Unknown Object (File)
Fri, Dec 13, 11:52 AM
Unknown Object (File)
Thu, Dec 5, 7:50 PM
Unknown Object (File)
Sat, Nov 30, 1:13 PM
Unknown Object (File)
Wed, Nov 27, 4:54 PM
Unknown Object (File)
Sat, Nov 23, 6:46 PM
Subscribers
None

Details

Summary

Ref T10978. This code (mostly related to the old ADD_AUDIT transaction and some to the "store English text in the database" audit reasons) is no longer reachable.

Test Plan

Grepped for removed symbols:

  • withAuditStatus
  • getActionNameMap (unrelated callsites exist)
  • getActionName (unrelated callsites exist)
  • getActionPastTenseVerb
  • addAuditReason
  • getAuditReasons
  • auditReasonMap

Also audited some commits.

Diff Detail

Repository
rP Phabricator
Branch
audit7x
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15416
Build 20314: Run Core Tests
Build 20313: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 30 2017, 10:14 PM
This revision was automatically updated to reflect the committed changes.