Page MenuHomePhabricator

Remove several pieces of audit-related code
ClosedPublic

Authored by epriestley on Jan 30 2017, 9:08 PM.
Tags
None
Referenced Files
F15402659: D17267.id41535.diff
Mon, Mar 17, 11:35 PM
F15387792: D17267.id.diff
Sat, Mar 15, 2:55 AM
F15333903: D17267.diff
Sat, Mar 8, 5:27 AM
F15331901: D17267.id41542.diff
Fri, Mar 7, 3:04 PM
F15331763: D17267.id41535.diff
Fri, Mar 7, 1:28 PM
F15331042: D17267.id.diff
Fri, Mar 7, 8:18 AM
F15284148: D17267.diff
Tue, Mar 4, 9:19 AM
Unknown Object (File)
Mon, Mar 3, 11:32 AM
Subscribers
None

Details

Summary

Ref T10978. This code (mostly related to the old ADD_AUDIT transaction and some to the "store English text in the database" audit reasons) is no longer reachable.

Test Plan

Grepped for removed symbols:

  • withAuditStatus
  • getActionNameMap (unrelated callsites exist)
  • getActionName (unrelated callsites exist)
  • getActionPastTenseVerb
  • addAuditReason
  • getAuditReasons
  • auditReasonMap

Also audited some commits.

Diff Detail

Repository
rP Phabricator
Branch
audit7x
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15416
Build 20314: Run Core Tests
Build 20313: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 30 2017, 10:14 PM
This revision was automatically updated to reflect the committed changes.