Page MenuHomePhabricator

Remove several pieces of audit-related code
ClosedPublic

Authored by epriestley on Jan 30 2017, 9:08 PM.
Tags
None
Referenced Files
F13093836: D17267.id.diff
Thu, Apr 25, 6:58 AM
F13090634: D17267.diff
Thu, Apr 25, 2:29 AM
Unknown Object (File)
Fri, Apr 19, 6:11 PM
Unknown Object (File)
Thu, Apr 11, 9:53 AM
Unknown Object (File)
Sun, Mar 31, 8:05 AM
Unknown Object (File)
Sun, Mar 31, 7:31 AM
Unknown Object (File)
Sun, Mar 31, 12:04 AM
Unknown Object (File)
Sat, Mar 30, 4:42 PM
Subscribers
None

Details

Summary

Ref T10978. This code (mostly related to the old ADD_AUDIT transaction and some to the "store English text in the database" audit reasons) is no longer reachable.

Test Plan

Grepped for removed symbols:

  • withAuditStatus
  • getActionNameMap (unrelated callsites exist)
  • getActionName (unrelated callsites exist)
  • getActionPastTenseVerb
  • addAuditReason
  • getAuditReasons
  • auditReasonMap

Also audited some commits.

Diff Detail

Repository
rP Phabricator
Branch
audit7x
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15416
Build 20314: Run Core Tests
Build 20313: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 30 2017, 10:14 PM
This revision was automatically updated to reflect the committed changes.