Page MenuHomePhabricator

Fix two issues with embedding other fields inside "Summary" or "Test Plan" in Differential with the web UI
ClosedPublic

Authored by epriestley on Jan 25 2017, 7:25 PM.
Tags
None
Referenced Files
F15392036: D17248.id41484.diff
Sat, Mar 15, 12:58 PM
F15390400: D17248.id41490.diff
Sat, Mar 15, 6:10 AM
F15389493: D17248.id41484.diff
Sat, Mar 15, 5:20 AM
F15385425: D17248.id41484.diff
Fri, Mar 14, 10:34 PM
Unknown Object (File)
Wed, Feb 26, 4:42 PM
Unknown Object (File)
Fri, Feb 21, 3:07 PM
Unknown Object (File)
Feb 11 2025, 7:25 PM
Unknown Object (File)
Feb 9 2025, 1:07 PM
Subscribers
None

Details

Summary

Ref T11114. Converting to EditEngine caused us to stop running this validation, since these fields no longer subclass this parent. Restore the validation.

Also, make sure we check the first line of the value, too. After the change to make "Tests: xyz" a valid title, you could write silly summaries / test plans and escape the check if the first line was bogus.

Test Plan

Screen Shot 2017-01-25 at 11.22.29 AM.png (1×1 px, 174 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable