Page MenuHomePhabricator

Fix two issues with embedding other fields inside "Summary" or "Test Plan" in Differential with the web UI
ClosedPublic

Authored by epriestley on Jan 25 2017, 7:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 5:39 PM
Unknown Object (File)
Oct 25 2024, 2:27 PM
Unknown Object (File)
Oct 23 2024, 8:05 PM
Unknown Object (File)
Oct 23 2024, 2:13 PM
Unknown Object (File)
Oct 23 2024, 6:11 AM
Unknown Object (File)
Oct 21 2024, 2:54 PM
Unknown Object (File)
Oct 9 2024, 6:58 AM
Unknown Object (File)
Sep 22 2024, 6:43 PM
Subscribers
None

Details

Summary

Ref T11114. Converting to EditEngine caused us to stop running this validation, since these fields no longer subclass this parent. Restore the validation.

Also, make sure we check the first line of the value, too. After the change to make "Tests: xyz" a valid title, you could write silly summaries / test plans and escape the check if the first line was bogus.

Test Plan

Screen Shot 2017-01-25 at 11.22.29 AM.png (1×1 px, 174 KB)

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15374
Build 20248: Run Core Tests
Build 20247: arc lint + arc unit