Page MenuHomePhabricator

Validate menu item fields (links, projects, dashboards, applications, forms, etc)
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 8:10 AM
Unknown Object (File)
Thu, Dec 19, 6:53 AM
Unknown Object (File)
Sun, Dec 15, 1:02 AM
Unknown Object (File)
Fri, Dec 13, 2:43 AM
Unknown Object (File)
Wed, Dec 11, 4:45 AM
Unknown Object (File)
Sat, Dec 7, 1:10 AM
Unknown Object (File)
Fri, Dec 6, 3:46 PM
Unknown Object (File)
Wed, Dec 4, 3:03 AM
Subscribers
None

Details

Summary

Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan
  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable