Page MenuHomePhabricator

Validate menu item fields (links, projects, dashboards, applications, forms, etc)
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 4:22 AM
Unknown Object (File)
Tue, Nov 19, 12:03 AM
Unknown Object (File)
Fri, Nov 15, 12:39 AM
Unknown Object (File)
Sun, Nov 10, 9:05 PM
Unknown Object (File)
Thu, Nov 7, 2:29 AM
Unknown Object (File)
Tue, Nov 5, 11:10 AM
Unknown Object (File)
Sat, Oct 26, 1:27 PM
Unknown Object (File)
Oct 24 2024, 7:58 PM
Subscribers
None

Details

Summary

Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan
  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable