Page MenuHomePhabricator

Validate menu item fields (links, projects, dashboards, applications, forms, etc)
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 16, 2:15 AM
Unknown Object (File)
Tue, Jun 14, 10:41 PM
Unknown Object (File)
Tue, Jun 7, 6:48 AM
Unknown Object (File)
Sat, Jun 4, 5:10 PM
Unknown Object (File)
Apr 14 2017, 10:49 PM
Unknown Object (File)
Apr 14 2017, 10:41 AM
Unknown Object (File)
Apr 12 2017, 5:10 PM
Unknown Object (File)
Mar 31 2017, 11:02 PM
Subscribers
None

Details

Summary

Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan
  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Diff Detail

Repository
rP Phabricator
Branch
validate1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15339
Build 20195: Run Core Tests
Build 20194: arc lint + arc unit