Page MenuHomePhabricator

Validate menu item fields (links, projects, dashboards, applications, forms, etc)
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:16 PM.
Tags
None
Referenced Files
F15386370: D17235.id41452.diff
Sat, Mar 15, 12:26 AM
F15381206: D17235.id41450.diff
Fri, Mar 14, 6:29 AM
F15338791: D17235.diff
Sun, Mar 9, 12:55 PM
Unknown Object (File)
Sun, Feb 23, 9:40 PM
Unknown Object (File)
Sun, Feb 23, 10:19 AM
Unknown Object (File)
Sun, Feb 23, 7:53 AM
Unknown Object (File)
Sat, Feb 22, 4:08 PM
Unknown Object (File)
Fri, Feb 21, 4:20 PM
Subscribers
None

Details

Summary

Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan
  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Diff Detail

Repository
rP Phabricator
Branch
validate1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15339
Build 20195: Run Core Tests
Build 20194: arc lint + arc unit