Page MenuHomePhabricator

Validate menu item fields (links, projects, dashboards, applications, forms, etc)
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:16 PM.
Tags
None
Referenced Files
F19244357: D17235.diff
Mon, Dec 22, 12:58 AM
F19103339: D17235.id.diff
Fri, Dec 5, 9:40 AM
F19096539: D17235.diff
Thu, Dec 4, 10:05 AM
F19052973: D17235.diff
Fri, Nov 28, 6:39 AM
F18973849: D17235.id41450.diff
Nov 15 2025, 5:40 PM
F18893710: D17235.id41452.diff
Nov 7 2025, 1:10 PM
F18860161: D17235.id.diff
Nov 2 2025, 9:51 AM
F18856263: D17235.diff
Nov 1 2025, 8:54 AM
Subscribers
None

Details

Summary

Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan
  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Diff Detail

Repository
rP Phabricator
Branch
validate1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15339
Build 20195: Run Core Tests
Build 20194: arc lint + arc unit