Page MenuHomePhabricator

Validate menu item fields (links, projects, dashboards, applications, forms, etc)
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:16 PM.
Tags
None
Referenced Files
F15490657: D17235.id41452.diff
Fri, Apr 11, 7:28 PM
F15485022: D17235.id41450.diff
Wed, Apr 9, 9:18 PM
F15463520: D17235.id41450.diff
Wed, Apr 2, 12:27 AM
F15461801: D17235.id.diff
Tue, Apr 1, 11:23 AM
F15441617: D17235.id41452.diff
Mar 26 2025, 6:53 PM
F15441616: D17235.id41450.diff
Mar 26 2025, 6:53 PM
F15441615: D17235.id.diff
Mar 26 2025, 6:53 PM
F15439326: D17235.diff
Mar 26 2025, 7:00 AM
Subscribers
None

Details

Summary

Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan
  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Diff Detail

Repository
rP Phabricator
Branch
validate1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15339
Build 20195: Run Core Tests
Build 20194: arc lint + arc unit