Page MenuHomePhabricator

Add an "Auditors" rule for Commits
ClosedPublic

Authored by epriestley on Jan 18 2017, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:06 PM
Unknown Object (File)
Fri, May 3, 10:10 AM
Unknown Object (File)
Thu, Apr 25, 3:42 AM
Unknown Object (File)
Tue, Apr 16, 12:36 PM
Unknown Object (File)
Thu, Apr 11, 10:50 AM
Unknown Object (File)
Mar 31 2024, 1:25 PM
Unknown Object (File)
Mar 30 2024, 3:56 AM
Unknown Object (File)
Mar 19 2024, 10:24 PM
Subscribers
None

Details

Summary

Fixes T5889. You can't write a rule like "if no other Herald rules did anything...", but you can use this rule to check for Owners or an explicit "Auditors" field doing things.

Test Plan

Using the test console, ran an "Auditors" rule against a commit with and without an auditor. Got expected pass/fail outcomes.

Diff Detail

Repository
rP Phabricator
Branch
audit4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15310
Build 20151: Run Core Tests
Build 20150: arc lint + arc unit