Page MenuHomePhabricator

Add an "Auditors" rule for Commits
ClosedPublic

Authored by epriestley on Jan 18 2017, 5:53 PM.
Tags
None
Referenced Files
F19043454: D17221.diff
Wed, Nov 26, 10:29 PM
F19016937: D17221.diff
Sun, Nov 23, 6:00 AM
F18844048: D17221.id.diff
Wed, Oct 29, 2:47 AM
F18816968: D17221.id.diff
Oct 21 2025, 10:59 AM
F18814413: D17221.diff
Oct 20 2025, 11:10 PM
F18790327: D17221.id41421.diff
Oct 15 2025, 1:39 PM
F18653505: D17221.diff
Sep 21 2025, 2:07 PM
F18651960: D17221.diff
Sep 21 2025, 6:08 AM
Subscribers
None

Details

Summary

Fixes T5889. You can't write a rule like "if no other Herald rules did anything...", but you can use this rule to check for Owners or an explicit "Auditors" field doing things.

Test Plan

Using the test console, ran an "Auditors" rule against a commit with and without an auditor. Got expected pass/fail outcomes.

Diff Detail

Repository
rP Phabricator
Branch
audit4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15310
Build 20151: Run Core Tests
Build 20150: arc lint + arc unit