Page MenuHomePhabricator

Make yellow "draft" bubbles more generic
ClosedPublic

Authored by epriestley on Jan 13 2017, 3:37 PM.
Tags
None
Referenced Files
F13212823: D17205.diff
Fri, May 17, 7:07 AM
F13197522: D17205.diff
Mon, May 13, 12:15 AM
F13178800: D17205.diff
Wed, May 8, 8:41 PM
F13173607: D17205.diff
Tue, May 7, 8:19 PM
Unknown Object (File)
Fri, May 3, 3:39 AM
Unknown Object (File)
Wed, May 1, 5:37 AM
Unknown Object (File)
Thu, Apr 25, 3:45 AM
Unknown Object (File)
Fri, Apr 19, 6:05 PM
Subscribers
None

Details

Summary

Fixes T12095. Ref T6660. The old code for this was specific to Differential, using the DifferentialDraft table.

Instead, make the EditEngine / VersionedDraft code create and remove a <objectPHID, authorPHID> edge when a particular author creates drafts.

Some applications have drafts beyond VersionedDrafts, notably inline comments. Before writing "yes, draft" or "no, no draft", ask the object if it has any custom draft stuff we need to know about.

This should fix all the yellow bubble bugs I created in T11114 and allow us to bring the feature to Audit fairly easily.

Test Plan

Created and deleted comments and inlines, reloading the list view after each change. Couldn't find a way to break the list view anymore.

Diff Detail

Repository
rP Phabricator
Branch
rev2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15254
Build 20057: Run Core Tests
Build 20056: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 4:50 PM
This revision was automatically updated to reflect the committed changes.