Paths

Table of Contentst

Get "Create Revision" out of Quick Create menu for now
ClosedPublic
Actions

Authored by epriestley on Jan 13 2017, 2:21 PM.

Tags

None

Referenced Files

	F15548160: D17204.id.diff
	Sat, Apr 26, 10:13 PM

	F15543310: D17204.diff
	Fri, Apr 25, 9:50 PM

	F15502704: D17204.id41367.diff
	Mon, Apr 14, 3:24 AM

	F15472583: D17204.id41367.diff
	Apr 5 2025, 2:50 PM

	F15459180: D17204.id41367.diff
	Mar 31 2025, 10:38 AM

	F15452296: D17204.id41365.diff
	Mar 29 2025, 3:38 AM

	F15442824: D17204.id.diff
	Mar 27 2025, 12:41 AM

	F15438386: D17204.diff
	Mar 26 2025, 12:28 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12098: Create Revision from FavoritesMenuItem doesn't work

Commits

rPe684794bf33d: Get "Create Revision" out of Quick Create menu for now

Summary

Ref T12098.

We have two methods (supportsEditEngineConfiguration() and isEngineConfigurable()) which sort of do the same thing and probably should be merged.

For now, just swap which one we override to get "Create Revision" out of the Quick Create menu.

Test Plan

No more "Create Revision" in Quick Create menu.

Diff Detail

Repository

rP Phabricator

Branch

rev1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15253
Build 20055: Run Core Tests
Build 20054: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 13 2017, 2:21 PM

Harbormaster completed remote builds in B15253: Diff 41365.Jan 13 2017, 2:23 PM

chad accepted this revision.Jan 13 2017, 2:51 PM

This revision is now accepted and ready to land.Jan 13 2017, 2:51 PM

Closed by commit rPe684794bf33d: Get "Create Revision" out of Quick Create menu for now (authored by epriestley, committed by epriestley). · Explain WhyJan 13 2017, 5:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

2 lines

Diff 41365

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Get "Create Revision" out of Quick Create menu for nowClosedPublicActions