Paths

Table of Contentst

Get "Create Revision" out of Quick Create menu for now
ClosedPublic
Actions

Authored by epriestley on Jan 13 2017, 2:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 2:31 AM

	Unknown Object (File)
	Tue, Nov 19, 6:14 PM

	Unknown Object (File)
	Sat, Nov 16, 8:01 AM

	Unknown Object (File)
	Tue, Nov 12, 6:44 AM

	Unknown Object (File)
	Fri, Nov 8, 1:14 PM

	Unknown Object (File)
	Oct 20 2024, 12:06 AM

	Unknown Object (File)
	Oct 19 2024, 9:54 PM

	Unknown Object (File)
	Oct 19 2024, 10:18 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12098: Create Revision from FavoritesMenuItem doesn't work

Commits

rPe684794bf33d: Get "Create Revision" out of Quick Create menu for now

Summary

Ref T12098.

We have two methods (supportsEditEngineConfiguration() and isEngineConfigurable()) which sort of do the same thing and probably should be merged.

For now, just swap which one we override to get "Create Revision" out of the Quick Create menu.

Test Plan

No more "Create Revision" in Quick Create menu.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 13 2017, 2:21 PM

Harbormaster completed remote builds in B15253: Diff 41365.Jan 13 2017, 2:23 PM

chad accepted this revision.Jan 13 2017, 2:51 PM

This revision is now accepted and ready to land.Jan 13 2017, 2:51 PM

Closed by commit rPe684794bf33d: Get "Create Revision" out of Quick Create menu for now (authored by epriestley, committed by epriestley). · Explain WhyJan 13 2017, 5:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

2 lines

Diff 41367

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Get "Create Revision" out of Quick Create menu for nowClosedPublicActions