Make "Audit Requested" put commits into the "Needs Audit" state
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 10:53 PM.

Tags

None

Referenced Files

	F19018884: D17185.diff
	Nov 23 2025, 12:35 PM

	F18870793: D17185.id.diff
	Nov 4 2025, 7:02 PM

	F18833685: D17185.diff
	Oct 26 2025, 5:06 AM

	F18784470: D17185.id41326.diff
	Oct 13 2025, 12:35 PM

	F18784463: D17185.id41328.diff
	Oct 13 2025, 12:35 PM

	F18784462: D17185.id.diff
	Oct 13 2025, 12:35 PM

	F18784389: D17185.diff
	Oct 13 2025, 12:26 PM

	F18772084: D17185.id41328.diff
	Oct 9 2025, 12:12 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T7504: Manually added auditors doesn't change commit audit status

Commits

rPc05cb1ba6ddd: Make "Audit Requested" put commits into the "Needs Audit" state

Summary

Fixes T7504. I think that task legitimately describes a bug and that the current behavior is counterintuitive.

Test Plan

Manually added an auditor to a commit with none; saw it become "Audit Required" as an overall state.

Diff Detail

Repository

rP Phabricator

Branch

commit10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15213
Build 19995: Run Core Tests
Build 19994: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 11 2017, 10:53 PM

Harbormaster completed remote builds in B15213: Diff 41326.Jan 11 2017, 10:53 PM

Harbormaster completed remote builds in B15213: Diff 41326.

chad accepted this revision.Jan 11 2017, 10:58 PM

This revision is now accepted and ready to land.Jan 11 2017, 10:58 PM

Closed by commit rPc05cb1ba6ddd: Make "Audit Requested" put commits into the "Needs Audit" state (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2017, 10:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepositoryCommit.php

1 line

Diff 41326

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Make "Audit Requested" put commits into the "Needs Audit" stateClosedPublicActions