Differential D17145

Make JX.Tooltip more conservative about positioning
ClosedPublic
Actions

Authored by epriestley on Jan 5 2017, 4:52 PM.

Details

Reviewers

chad

Maniphest Tasks

T10687: jx-tooltip does whatever it feels like
T12064: Tooltip for "Preview" in comment box overflows horizontally

Commits

rP5ff02058a4b0: Make JX.Tooltip more conservative about positioning

Summary

Fixes T10687. Fixes T12064.

Primarily, adds a margin around the edge of the screen for the purposes of aligning the tooltip.
Also, tries to flip the tooltip if it can (e.g., if the tooltip normally goes east, try west first), then tries other positions exhastively.

Test Plan

Screen Shot 2017-01-05 at 8.48.28 AM.png (207×226 px, 8 KB)

Screen Shot 2017-01-05 at 8.49.17 AM.png (266×318 px, 15 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 5 2017, 4:52 PM

Harbormaster completed remote builds in B15116: Diff 41232.Jan 5 2017, 4:54 PM

8071526975_7bc933b835.jpg (375×500 px, 69 KB)

Curiously, this did not transition to "Accepted".

chad accepted this revision.Jan 5 2017, 5:05 PM

This revision is now accepted and ready to land.Jan 5 2017, 5:05 PM

frowncat

I think "Accept" + "Comment" may be interacting, probably not too tricky to fix.

Closed by commit rP5ff02058a4b0: Make JX.Tooltip more conservative about positioning (authored by epriestley, committed by epriestley). · Explain WhyJan 6 2017, 12:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

18 lines

webroot/

rsrc/

js/

core/

ToolTip.js

109 lines

Diff 41240

View Options

resources/celerity/map.php