Page MenuHomePhabricator
Differential D17145

Make JX.Tooltip more conservative about positioning
ClosedPublic
Actions

Authored by epriestley on Jan 5 2017, 4:52 PM.
Tags
None
Referenced Files
F13062364: D17145.id41232.diff
Fri, Apr 19, 11:21 PM
F13060554: D17145.diff
Fri, Apr 19, 6:01 PM
Unknown Object (File)
Fri, Apr 12, 4:44 PM
Unknown Object (File)
Mon, Apr 8, 4:25 PM
Unknown Object (File)
Mon, Apr 8, 4:04 PM
Unknown Object (File)
Sun, Apr 7, 4:51 PM
Unknown Object (File)
Fri, Apr 5, 8:53 AM
Unknown Object (File)
Fri, Apr 5, 6:09 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10687: jx-tooltip does whatever it feels like
T12064: Tooltip for "Preview" in comment box overflows horizontally
Commits
rP5ff02058a4b0: Make JX.Tooltip more conservative about positioning
Summary

Fixes T10687. Fixes T12064.

  • Primarily, adds a margin around the edge of the screen for the purposes of aligning the tooltip.
  • Also, tries to flip the tooltip if it can (e.g., if the tooltip normally goes east, try west first), then tries other positions exhastively.
Test Plan

Screen Shot 2017-01-05 at 8.48.28 AM.png (207×226 px, 8 KB)

Screen Shot 2017-01-05 at 8.49.17 AM.png (266×318 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Branch
tooltip
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15116
Build 19847: Run Core Tests
Build 19846: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 5 2017, 4:52 PM
Harbormaster completed remote builds in B15116: Diff 41232.Jan 5 2017, 4:54 PM
chad accepted this revision.Jan 5 2017, 5:01 PM
chad edited edge metadata.

8071526975_7bc933b835.jpg (375×500 px, 69 KB)

epriestley added a comment.Jan 5 2017, 5:03 PM

Curiously, this did not transition to "Accepted".

chad accepted this revision.Jan 5 2017, 5:05 PM
This revision is now accepted and ready to land.Jan 5 2017, 5:05 PM
chad added a comment.Jan 5 2017, 5:05 PM

frowncat

epriestley added a comment.Jan 5 2017, 5:07 PM

I think "Accept" + "Comment" may be interacting, probably not too tricky to fix.

chad added a comment.Jan 5 2017, 5:17 PM

11-490.png (480×640 px, 26 KB)

Closed by commit rP5ff02058a4b0: Make JX.Tooltip more conservative about positioning (authored by epriestley, committed by epriestley). · Explain WhyJan 6 2017, 12:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
webroot/
rsrc/
js/
core/
109 lines

Diff 41232

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/core/ToolTip.js

Loading...
Phabricator · Built by Phacility