Page MenuHomePhabricator

Fix a case where "Accept + Comment" would ignore the "Accept"
ClosedPublic

Authored by epriestley on Jan 5 2017, 7:17 PM.
Tags
None
Referenced Files
F13207109: D17146.id41235.diff
Wed, May 15, 9:33 PM
F13195444: D17146.diff
Sun, May 12, 10:24 PM
F13179532: D17146.diff
Wed, May 8, 9:15 PM
Unknown Object (File)
Sat, May 4, 6:50 PM
Unknown Object (File)
Wed, May 1, 11:04 PM
Unknown Object (File)
Tue, Apr 30, 11:30 PM
Unknown Object (File)
Sun, Apr 28, 2:10 PM
Unknown Object (File)
Sat, Apr 27, 11:21 AM
Subscribers
None

Details

Summary

Ref T11114. When you comment, we try to upgrade your review status to "commented".

This can conflict with upgrading it to "accepted" or "rejected", or removing it entirely.

For now, just avoid making this update. After T10967, I expect "you commented" to be orthogonal to accepted/rejected so it should stop conflicting on its own.

Test Plan
  • As an "added" reviewer, accepted a revision with a comment in the same transaction.
  • Before patch: accept didn't stick.
  • After patch: accept sticks.

This may be somewhat magical/order-dependent but I was able to reproduce it locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable