Page MenuHomePhabricator

Fix a case where "Accept + Comment" would ignore the "Accept"
ClosedPublic

Authored by epriestley on Jan 5 2017, 7:17 PM.
Tags
None
Referenced Files
F15476294: D17146.id.diff
Mon, Apr 7, 5:08 AM
F15438567: D17146.id.diff
Wed, Mar 26, 1:35 AM
F15432747: D17146.diff
Mon, Mar 24, 7:35 PM
F15382544: D17146.id41235.diff
Fri, Mar 14, 12:58 PM
F15334336: D17146.diff
Mar 8 2025, 8:19 AM
F15307367: D17146.diff
Mar 6 2025, 5:04 AM
Unknown Object (File)
Mar 1 2025, 9:18 PM
Unknown Object (File)
Feb 21 2025, 3:01 PM
Subscribers
None

Details

Summary

Ref T11114. When you comment, we try to upgrade your review status to "commented".

This can conflict with upgrading it to "accepted" or "rejected", or removing it entirely.

For now, just avoid making this update. After T10967, I expect "you commented" to be orthogonal to accepted/rejected so it should stop conflicting on its own.

Test Plan
  • As an "added" reviewer, accepted a revision with a comment in the same transaction.
  • Before patch: accept didn't stick.
  • After patch: accept sticks.

This may be somewhat magical/order-dependent but I was able to reproduce it locally.

Diff Detail

Repository
rP Phabricator
Branch
review1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15118
Build 19850: Run Core Tests
Build 19849: arc lint + arc unit