Page MenuHomePhabricator
Differential D17138

Update diff highlight colors for better color blindess distinction
ClosedPublic
Actions

Authored by chad on Jan 4 2017, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 3:49 AM
Unknown Object (File)
Sat, May 4, 7:10 PM
Unknown Object (File)
Thu, May 2, 12:13 AM
Unknown Object (File)
Wed, May 1, 12:49 AM
Unknown Object (File)
Sat, Apr 27, 4:26 AM
Unknown Object (File)
Fri, Apr 19, 6:00 PM
Unknown Object (File)
Thu, Apr 11, 10:38 AM
Unknown Object (File)
Apr 6 2024, 9:29 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12060: Colorblind accessibility for red/green highlighting in e-mails
Commits
rPaa9708c5d33c: Update diff highlight colors for better color blindess distinction
Summary

Tweaks the diff colors here a bit, as well as making full diffs slightly easier to read in full. Ref T12060

Test Plan

Tested prose diffs, email prose diffs, and a regular Differential revision.

pasted_file (1×2 px, 371 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Jan 4 2017, 7:22 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJan 4 2017, 7:22 PM
epriestley accepted this revision.Jan 4 2017, 7:23 PM
This revision is now accepted and ready to land.Jan 4 2017, 7:23 PM
chad edited the test plan for this revision. (Show Details)Jan 4 2017, 7:24 PM
Closed by commit rPaa9708c5d33c: Update diff highlight colors for better color blindess distinction (authored by chad, committed by chad). · Explain WhyJan 4 2017, 7:35 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Jan 4 2017, 9:27 PM

I can barely see the light green shade now, but maybe just a monitor issue unique to me. Light red is OK.

epriestley added a comment.Jan 4 2017, 9:28 PM

Well, maybe "barely see" is a little dramatic. But it's light enough that scanning the right-hand-side of two-up diffs for new blocks of code feels harder than it used to be.

chad added a comment.Jan 4 2017, 9:29 PM

I changed new-full to be light instead of bright, maybe that's it?

chad added a comment.Jan 4 2017, 9:29 PM

(it felt too overpowering with a richer green)

chad added a comment.Jan 4 2017, 9:30 PM

I can bring light green up a hair

epriestley mentioned this in T12089: New red/green highlight colors are incorrect for added or removed new lines.Jan 10 2017, 7:09 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
transactions/
view/
8 lines
webroot/
rsrc/
css/
application/
differential/
23 lines

Diff 41215

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility