Page MenuHomePhabricator

Update diff highlight colors for better color blindess distinction
ClosedPublic

Authored by chad on Jan 4 2017, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:00 PM
Unknown Object (File)
Thu, Apr 11, 10:38 AM
Unknown Object (File)
Sat, Apr 6, 9:29 PM
Unknown Object (File)
Fri, Apr 5, 6:17 AM
Unknown Object (File)
Mar 3 2024, 7:32 AM
Unknown Object (File)
Feb 13 2024, 12:11 PM
Unknown Object (File)
Feb 12 2024, 6:36 AM
Unknown Object (File)
Feb 7 2024, 2:57 PM
Subscribers

Details

Summary

Tweaks the diff colors here a bit, as well as making full diffs slightly easier to read in full. Ref T12060

Test Plan

Tested prose diffs, email prose diffs, and a regular Differential revision.

pasted_file (1×2 px, 371 KB)

Diff Detail

Repository
rP Phabricator
Branch
diff-colors (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15099
Build 19821: Run Core Tests
Build 19820: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 4 2017, 7:23 PM
This revision was automatically updated to reflect the committed changes.

I can barely see the light green shade now, but maybe just a monitor issue unique to me. Light red is OK.

Well, maybe "barely see" is a little dramatic. But it's light enough that scanning the right-hand-side of two-up diffs for new blocks of code feels harder than it used to be.

I changed new-full to be light instead of bright, maybe that's it?

(it felt too overpowering with a richer green)

I can bring light green up a hair