Page MenuHomePhabricator

Make some Differential comment actions (like "Accept" and "Reject") conflict with one another
ClosedPublic

Authored by epriestley on Jan 2 2017, 7:22 PM.
Tags
None
Referenced Files
F14055956: D17132.diff
Sat, Nov 16, 5:06 PM
F14039779: D17132.id41201.diff
Mon, Nov 11, 6:17 AM
F14014621: D17132.id41201.diff
Sun, Nov 3, 6:24 AM
F13976869: D17132.diff
Oct 18 2024, 4:04 PM
Unknown Object (File)
Sep 20 2024, 5:06 PM
Unknown Object (File)
Sep 18 2024, 1:15 PM
Unknown Object (File)
Sep 15 2024, 7:05 PM
Unknown Object (File)
Sep 15 2024, 6:25 PM
Subscribers
None

Details

Summary

Ref T11114. When a user selects "Accept", and then selects "Reject", remove the "Accept". It does not make sense to both accept and reject a revision.

For now, every one of the "actions" conflicts: accept, reject, resign, claim, close, commandeer, etc, etc. I couldn't come up with any combinations that it seems like users are reasonably likely to want to try, and we haven't received combo-action requests in the past that I can recall.

Test Plan
  • Selected "Accept", then selected "Reject". One replaced the other.
  • Selected "Accept", then selected "Change Subscribers". Both co-existed happily.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 2 2017, 7:36 PM
This revision was automatically updated to reflect the committed changes.