Page MenuHomePhabricator

Make some Differential comment actions (like "Accept" and "Reject") conflict with one another
ClosedPublic

Authored by epriestley on Jan 2 2017, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:04 AM
Unknown Object (File)
Sun, Apr 21, 10:38 AM
Unknown Object (File)
Fri, Apr 19, 6:00 PM
Unknown Object (File)
Mon, Apr 8, 2:01 PM
Unknown Object (File)
Sun, Apr 7, 1:12 PM
Unknown Object (File)
Sun, Apr 7, 8:09 AM
Unknown Object (File)
Apr 2 2024, 3:39 AM
Unknown Object (File)
Mar 30 2024, 3:49 AM
Subscribers
None

Details

Summary

Ref T11114. When a user selects "Accept", and then selects "Reject", remove the "Accept". It does not make sense to both accept and reject a revision.

For now, every one of the "actions" conflicts: accept, reject, resign, claim, close, commandeer, etc, etc. I couldn't come up with any combinations that it seems like users are reasonably likely to want to try, and we haven't received combo-action requests in the past that I can recall.

Test Plan
  • Selected "Accept", then selected "Reject". One replaced the other.
  • Selected "Accept", then selected "Change Subscribers". Both co-existed happily.

Diff Detail

Repository
rP Phabricator
Branch
diff2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15083
Build 19797: Run Core Tests
Build 19796: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 2 2017, 7:36 PM
This revision was automatically updated to reflect the committed changes.