Page MenuHomePhabricator

Make some Differential comment actions (like "Accept" and "Reject") conflict with one another
ClosedPublic

Authored by epriestley on Jan 2 2017, 7:22 PM.
Tags
None
Referenced Files
F19556559: D17132.id.diff
Jan 30 2026, 8:05 PM
F19467053: D17132.diff
Jan 3 2026, 12:50 PM
F18877347: D17132.id.diff
Nov 6 2025, 7:38 AM
F18873935: D17132.diff
Nov 5 2025, 12:15 PM
F18854162: D17132.diff
Oct 31 2025, 10:02 PM
F18837929: D17132.diff
Oct 27 2025, 8:28 AM
F18833666: D17132.diff
Oct 26 2025, 5:06 AM
F18816199: D17132.id41201.diff
Oct 21 2025, 5:27 AM
Subscribers
None

Details

Summary

Ref T11114. When a user selects "Accept", and then selects "Reject", remove the "Accept". It does not make sense to both accept and reject a revision.

For now, every one of the "actions" conflicts: accept, reject, resign, claim, close, commandeer, etc, etc. I couldn't come up with any combinations that it seems like users are reasonably likely to want to try, and we haven't received combo-action requests in the past that I can recall.

Test Plan
  • Selected "Accept", then selected "Reject". One replaced the other.
  • Selected "Accept", then selected "Change Subscribers". Both co-existed happily.

Diff Detail

Repository
rP Phabricator
Branch
diff2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15083
Build 19797: Run Core Tests
Build 19796: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 2 2017, 7:36 PM
This revision was automatically updated to reflect the committed changes.