Page MenuHomePhabricator

Order actions sensibly within Differential revision comment action groups
ClosedPublic

Authored by epriestley on Dec 29 2016, 9:44 PM.
Tags
None
Referenced Files
F13197308: D17115.diff
Mon, May 13, 12:04 AM
F13193194: D17115.diff
Sun, May 12, 12:50 PM
Unknown Object (File)
Sat, May 4, 3:21 PM
Unknown Object (File)
Fri, May 3, 11:13 PM
Unknown Object (File)
Fri, May 3, 9:12 AM
Unknown Object (File)
Fri, May 3, 12:58 AM
Unknown Object (File)
Thu, May 2, 11:43 AM
Unknown Object (File)
Mon, Apr 29, 3:41 AM
Subscribers
None

Details

Summary

Ref T11114. See D17114 for some discussion.

For review actions: accept, reject, resign.

For revision actions, order is basically least-severe to most-severe action pairs: plan changes, request review, close, reopen, abandon, reclaim, commandeer.

Test Plan

Viewed revisions as an author and a reviewer, saw sensible action order within action groups.

Diff Detail

Repository
rP Phabricator
Branch
haunt9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15045
Build 19744: Run Core Tests
Build 19743: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.