Page MenuHomePhabricator

Order actions sensibly within Differential revision comment action groups
ClosedPublic

Authored by epriestley on Dec 29 2016, 9:44 PM.
Tags
None
Referenced Files
F15454039: D17115.id41172.diff
Sat, Mar 29, 3:56 PM
F15448831: D17115.id.diff
Fri, Mar 28, 7:06 AM
F15445377: D17115.diff
Thu, Mar 27, 1:37 PM
F15434696: D17115.id41172.diff
Tue, Mar 25, 4:56 AM
F15414637: D17115.id41158.diff
Thu, Mar 20, 1:42 AM
F15388242: D17115.diff
Sat, Mar 15, 3:31 AM
F15339114: D17115.diff
Sun, Mar 9, 2:26 PM
Unknown Object (File)
Feb 24 2025, 10:57 PM
Subscribers
None

Details

Summary

Ref T11114. See D17114 for some discussion.

For review actions: accept, reject, resign.

For revision actions, order is basically least-severe to most-severe action pairs: plan changes, request review, close, reopen, abandon, reclaim, commandeer.

Test Plan

Viewed revisions as an author and a reviewer, saw sensible action order within action groups.

Diff Detail

Repository
rP Phabricator
Branch
haunt9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15045
Build 19744: Run Core Tests
Build 19743: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.