Page MenuHomePhabricator

Order actions sensibly within Differential revision comment action groups
ClosedPublic

Authored by epriestley on Dec 29 2016, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 2 2026, 2:13 PM
Unknown Object (File)
Apr 1 2026, 5:30 AM
Unknown Object (File)
Mar 31 2026, 11:35 AM
Unknown Object (File)
Mar 11 2026, 1:27 PM
Unknown Object (File)
Mar 4 2026, 8:35 AM
Unknown Object (File)
Feb 15 2026, 5:18 PM
Unknown Object (File)
Feb 3 2026, 5:43 AM
Unknown Object (File)
Feb 1 2026, 8:57 AM
Subscribers
None

Details

Summary

Ref T11114. See D17114 for some discussion.

For review actions: accept, reject, resign.

For revision actions, order is basically least-severe to most-severe action pairs: plan changes, request review, close, reopen, abandon, reclaim, commandeer.

Test Plan

Viewed revisions as an author and a reviewer, saw sensible action order within action groups.

Diff Detail

Repository
rP Phabricator
Branch
haunt9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15045
Build 19744: Run Core Tests
Build 19743: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.