Page MenuHomePhabricator

Order actions sensibly within Differential revision comment action groups
ClosedPublic

Authored by epriestley on Dec 29 2016, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 5:59 PM
Unknown Object (File)
Thu, Apr 11, 10:09 AM
Unknown Object (File)
Tue, Apr 2, 10:36 PM
Unknown Object (File)
Sat, Mar 30, 3:46 AM
Unknown Object (File)
Thu, Mar 28, 1:35 PM
Unknown Object (File)
Tue, Mar 26, 7:11 PM
Unknown Object (File)
Tue, Mar 26, 7:11 PM
Unknown Object (File)
Tue, Mar 26, 7:11 PM
Subscribers
None

Details

Summary

Ref T11114. See D17114 for some discussion.

For review actions: accept, reject, resign.

For revision actions, order is basically least-severe to most-severe action pairs: plan changes, request review, close, reopen, abandon, reclaim, commandeer.

Test Plan

Viewed revisions as an author and a reviewer, saw sensible action order within action groups.

Diff Detail

Repository
rP Phabricator
Branch
haunt9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15045
Build 19744: Run Core Tests
Build 19743: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.