Page MenuHomePhabricator

Restore "Plan Changes" and "Request Review" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 9:42 PM.
Tags
None
Referenced Files
F13353958: D17109.id41148.diff
Mon, Jun 24, 1:18 AM
F13346875: D17109.diff
Fri, Jun 21, 9:44 PM
F13339226: D17109.diff
Wed, Jun 19, 3:48 PM
F13338442: D17109.diff
Wed, Jun 19, 10:56 AM
F13289954: D17109.diff
Tue, Jun 4, 2:21 PM
F13277147: D17109.diff
Fri, May 31, 8:37 AM
F13242484: D17109.diff
May 23 2024, 2:48 AM
F13192615: D17109.diff
May 12 2024, 9:03 AM
Subscribers
None

Details

Summary

Ref T11114. This restores these actions.

One behavior is incomplete: "Request Review" on an accepted revision does not downgrade reviewers properly. I've noted this locally.

Test Plan

Planned changes and requested review of a revision.

Diff Detail

Repository
rP Phabricator
Branch
haunt5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15035
Build 19727: Run Core Tests
Build 19726: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:59 PM
This revision was automatically updated to reflect the committed changes.