Page MenuHomePhabricator

Restore "Plan Changes" and "Request Review" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 9:42 PM.
Tags
None
Referenced Files
F19828063: D17109.diff
Mon, Mar 9, 3:59 PM
F19822930: D17109.id41148.diff
Sat, Mar 7, 9:29 AM
F19822928: D17109.id41148.diff
Sat, Mar 7, 9:25 AM
F19523790: D17109.id.diff
Jan 17 2026, 7:32 PM
F19467940: D17109.diff
Jan 3 2026, 8:16 PM
F19178093: D17109.diff
Dec 16 2025, 12:34 AM
F18936142: D17109.id41148.diff
Nov 10 2025, 7:49 PM
F18879275: D17109.id.diff
Nov 6 2025, 6:21 PM
Subscribers
None

Details

Summary

Ref T11114. This restores these actions.

One behavior is incomplete: "Request Review" on an accepted revision does not downgrade reviewers properly. I've noted this locally.

Test Plan

Planned changes and requested review of a revision.

Diff Detail

Repository
rP Phabricator
Branch
haunt5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15035
Build 19727: Run Core Tests
Build 19726: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:59 PM
This revision was automatically updated to reflect the committed changes.